Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crop grid : gesture, aspect ratio, and painting area #87

Merged
merged 10 commits into from
Apr 11, 2022

Conversation

LeGoffMael
Copy link
Owner

@LeGoffMael LeGoffMael commented Apr 7, 2022

This PR changes a lot of things in order to fix a lot of bugs:

List of fixes:

  • When the aspect ratio was updated, the crop area kept getting smaller
  • Some corner of the crop was not resizing properly (ie: topRight)
  • The crop painter sometimes had spaces between the rects, this should be now definitely fixed using path difference combination
  • The edges boundaries of the crop grid had similar problem, the rects overlay each other now
Before: ratio keep getting smaller + spaces between rect in paint area With this PR: ratio change depending of size and no more space in paint area
RPReplay_Final1649309413.mov
RPReplay_Final1649325522.2.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant