Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests not closing because application server process is still running #76

Closed
LeNPaul opened this issue Oct 24, 2019 · 1 comment
Assignees
Labels
fix For any bug fixes

Comments

@LeNPaul
Copy link
Owner

LeNPaul commented Oct 24, 2019

See:

@LeNPaul LeNPaul added the fix For any bug fixes label Oct 24, 2019
@LeNPaul LeNPaul self-assigned this Oct 24, 2019
LeNPaul added a commit that referenced this issue Oct 26, 2019
LeNPaul added a commit that referenced this issue Oct 26, 2019
… instead of creating its own (which doesn't automatically close after tests are done) and remove the --exit flag
@LeNPaul LeNPaul closed this as completed Oct 26, 2019
@LeNPaul
Copy link
Owner Author

LeNPaul commented Oct 26, 2019

For some reason, when letting chai-http create its own server application when it is running its tests, the server application does not automatically close. This might indicate that there is something in the server application code that is never gracefully closed (only forcefully closed even when it is running normally).

The solution right now is to point chai-http to a server application that is currently running on the server. The tests will finish and close since chai-http is not managing the server application (only making calls to the currently running server application), and the server application on the server will be closed separately like usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix For any bug fixes
Projects
None yet
Development

No branches or pull requests

1 participant