Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement enchanting. #272

Open
2 of 3 tasks
skillman623 opened this issue Feb 26, 2023 · 3 comments
Open
2 of 3 tasks

Implement enchanting. #272

skillman623 opened this issue Feb 26, 2023 · 3 comments

Comments

@skillman623
Copy link

skillman623 commented Feb 26, 2023 •
edited

@skillman623 skillman623 changed the title Impliment enchanting. Implement enchanting. Feb 26, 2023
@terrarier2111
Copy link
Member

Status effects seem unrelated to enchanting, should we maybe remove them from here or am i missing something?

@skillman623
Copy link
Author

Status effects seem unrelated to enchanting, should we maybe remove them from here or am i missing something?

I was thinking it might be needed for feather falling, drowning prevention (water breathing), fire aspect, and other related effects. If they are implemented as placeholders, this can be removed from the list.

@terrarier2111
Copy link
Member

Status effects seem unrelated to enchanting, should we maybe remove them from here or am i missing something?

I was thinking it might be needed for feather falling, drowning prevention (water breathing), fire aspect, and other related effects. If they are implemented as placeholders, this can be removed from the list.

Status effects affect in-game behavior, as do enchantments - that's pretty much all they have in common

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skillman623 @terrarier2111