Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor break blocks to use calculated mining time #247

Merged
merged 11 commits into from Sep 30, 2022

Conversation

nathanruiz
Copy link
Collaborator

I've added basic support for breaking blocks. At the moment, it can calculate the time required to mine each block for each tool with these exceptions:

  • Using swords: Cobwebs, cocoa, leaves, melons, pumpkins, vines
  • Using shears: Cobwebs, wool, leaves, vines

As part of this, I moved some of the existing code from Server into an ECS system to make it easier to maintain.

@terrarier2111
Copy link
Member

Looks like you have to apply cargofmt to make CI pass

@nathanruiz
Copy link
Collaborator Author

@terrarier2111 I've run the formatter, checks are passing now.

Copy link
Member

@terrarier2111 terrarier2111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the network thingy this change looks great, thank you!

src/server/mod.rs Outdated Show resolved Hide resolved
@terrarier2111 terrarier2111 merged commit 928ae20 into Lea-fish:main Sep 30, 2022
@nathanruiz nathanruiz deleted the digging branch September 30, 2022 17:07
@skillman623 skillman623 mentioned this pull request Feb 26, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants