Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #202: $.fetch support for multipart #203

Closed
wants to merge 1 commit into from
Closed

Fixes #202: $.fetch support for multipart #203

wants to merge 1 commit into from

Conversation

friday
Copy link
Contributor

@friday friday commented Oct 23, 2017

This implements the suggestion in #202 in order to support multipart in $.fetch.

There hasn't been any discussion in #202, so this may not be desirable. After all it's a "breaking" change.

@LeaVerou
Copy link
Owner

This seems to be adding an unrelated check to fix a different problem than what that check is testing. It's a heuristic, and not sure if it's a good heuristic. And as you mention, it could break some legit use cases.

You can already pass specific headers, via the headers parameter. So, in theory, headers: { "Content-Type": undefined } should fix this problem. If not, I'd be glad to merge a PR along these lines.

Thanks for contributing, and I hope this doesn’t put you off future contributions!

@LeaVerou LeaVerou closed this Oct 25, 2017
@friday friday deleted the issue/202 branch October 26, 2017 03:19
@friday
Copy link
Contributor Author

friday commented Oct 26, 2017

No worries :) That's your job as a maintainer, and it was probably a good call. I'll try to justify this PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants