Adding tests for $.clone()

[AVGP]

Taking care of #67

[LeaVerou]

Hey there, thanks for contributing!
However, the main thing that $.clone() does is copy events. Everything else is already handled just fine by the native element.cloneNode(true). So, this is what we need to test for, otherwise you're just testing the browser's native implementation of cloneNode :P

[AVGP]

Right, shouldn't code when tired. Let me fix the test :)

[AVGP]

...actually... shall I leave this here or remove it more or less entirely and just test events then?

[LeaVerou]

I think it doesn't hurt to test other things as well, but the main things to test here are events, on both the cloned element and the descendants.

[LeaVerou]

@zdfs I thought we were trying to avoid using other Bliss methods (besides the one being tested) in tests, which I thought was a good idea. Should we document that somewhere, if it's actually a rule?

[AVGP]

@LeaVerou Quick question, this test should pass, no?

    var element = $.create("div", { class: "parent",  contents: "This is the parent" });
    element._.delegate("click", "p", function() {
      done();
    });

    var child = $.create("p");
    element.appendChild(child);

    var clone = $.clone(element);

    var ev = document.createEvent("MouseEvent");
        ev.initMouseEvent("click", true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
    clone.childNodes[1].dispatchEvent(ev);

[zdfs]

@LeaVerou - Shit. I wasn't aware of that. I've actually been doing the opposite. If that's something you like, we should document it.

[LeaVerou]

@zdfs I have no strong opinion, it's just something I noticed as a pattern in other tests. I thought it made sense, since if it doesn't pass, we know for a fact which part of Bliss is problematic. Don't go back changing all your tests though! Let's just document it and try to follow it from now on :)

@AVGP Oh, nice one! It should pass, yes! Btw, please try to avoid using Bliss functions other than the one being tested (see the side discussion with @zdfs)

[zdfs]

@LeaVerou - It shouldn't be difficult for me to clean my tests up.

Do we need to do anything else here? Should we wait for the extraneous Bliss functions to come out?

[AVGP]

@LeaVerou
1.) Well, that test doesn't pass.. is that a bug in Bliss.js then?
2.) Will clean up my tests. I literally copied that style from existing tests ^^"

[LeaVerou]

@AVGP

1. Yes, it looks like you have! Congrats!
2. Thanks!

[AVGP]

@LeaVerou Hurray! The test has already payed off :P

[AVGP]

@LeaVerou Does this look good to you now?

[zdfs]

I'll merge this in since everything seems to be passing. If we need to refactor later, we will.