Added support for nth-child(An+b of ...) #18
Conversation
As specified in https://www.w3.org/TR/selectors-4/#nth-child-pseudo (and implemented in WebKit) Parse the subtree after the "of" keyword for nth-child/nth-last-child
parsel.js
Outdated
| if (node.type === "pseudo-class" && node.argument) { | ||
| if (RECURSIVE_PSEUDO_CLASSES.has(node.name)) { | ||
| node.subtree = parse(node.argument, {recursive: true, list: true}); | ||
| } else if (INDEX_PSEUDO_CLASSES.has(node.name)) { |
There was a problem hiding this comment.
What is INDEX_PSEUDO_CLASSES supposed to contain? The name implies it's more general, but the code matches a specific microsyntax that applies to :nth-child() and :nth-last-child()
Essentially this is a recursive pseudo-class with additional metadata, I wonder if we just need a data structure for that (e.g. RECURSIVE_PSEUDO_CLASSS_ARG)
There was a problem hiding this comment.
I don't exactly follow what RECURSIVE_PSEUDO_CLASSS_ARG would contain. the /([\dn+-]+)\s+of/ regex?
There was a problem hiding this comment.
Yup! With named groups for the additional parameters you want to extract.
Sure, let's see what's needed :) |
| export const RECURSIVE_PSEUDO_CLASSES_ARGS = { | ||
| "nth-child": NTH_CHILD_ARG, | ||
| "nth-last-child": NTH_CHILD_ARG | ||
| } |
There was a problem hiding this comment.
Nit: I think it would be better to do RECURSIVE_PSEUDO_CLASSES_ARGS['nth-last-child'] = RECURSIVE_PSEUDO_CLASSES_ARGS['nth-child'] after than to define another constant which looks like it's significant, but is essentially just a helper.
|
Thank you for iterating on this and being open to feedback. Merged! |
My pleasure. Hope to contribute more to this in the future. |
As specified in https://www.w3.org/TR/selectors-4/#nth-child-pseudo
(and implemented in WebKit)
Parse the subtree after the "of" keyword for nth-child/nth-last-child