Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TypeScript #49

Closed
wants to merge 2 commits into from
Closed

Use TypeScript #49

wants to merge 2 commits into from

Conversation

jrandolf
Copy link
Collaborator

@jrandolf jrandolf commented Mar 6, 2023

This PR rewrites Parsel with TypeScript. This allows for precise typing and better compatibility with future TypeScript without the manual typing.

@LeaVerou
Copy link
Owner

LeaVerou commented Mar 6, 2023

Hey, thank you so much for working on Parsel!

Please break this down into multiple PRs so it can be reviewed and merged separately. I know this is a hassle, but as it currently stands, it's very difficult to review, and there is no way to only accept some of the changes and not others.

This is standard in every open source project, huge PRs with multiple unrelated changes are considered an antipattern. It is also typically a good idea to consult maintainers before making radical changes to the codebase.

@bramus
Copy link
Contributor

bramus commented Mar 7, 2023

+1 to what @LeaVerou said. I can see several parts which I also considered (such as moving the tests to an automated test suite, excluding the built files, etc) but to merge/accept them they’d need to have their own PR.

@netlify
Copy link

netlify bot commented Mar 8, 2023

Deploy Preview for parsel ready!

Name Link
🔨 Latest commit c7e9b8c
🔍 Latest deploy log https://app.netlify.com/sites/parsel/deploys/6407f9b537809b0008286fbf
😎 Deploy Preview https://deploy-preview-49--parsel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jrandolf jrandolf changed the title Bug fixes and TypeScript refactor Use TypeScript Mar 8, 2023
@jrandolf jrandolf mentioned this pull request Mar 8, 2023
@jrandolf
Copy link
Collaborator Author

jrandolf commented Mar 8, 2023

Sorry, actually I'll reopen #53. I need the master branch.

@jrandolf jrandolf closed this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants