Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move public assets to public #62

Closed
wants to merge 1 commit into from
Closed

Conversation

jrandolf
Copy link
Collaborator

No description provided.

@jrandolf jrandolf requested a review from LeaVerou March 15, 2023 01:40
@netlify
Copy link

netlify bot commented Mar 15, 2023

Deploy Preview for parsel ready!

Name Link
🔨 Latest commit 15eb617
🔍 Latest deploy log https://app.netlify.com/sites/parsel/deploys/6411eb488799ce0008a065fa
😎 Deploy Preview https://deploy-preview-62--parsel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Owner

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to move CSS and unrelated JS files to a separate folder for tidyness, but moving the entire website to a separate folder means we now need to be building copies of Parsel, one for dist/ and one for the website itself. What is the advantage of this additional complexity?

(I'm less opposed to it as in other projects that don't depend on a build process as much, but I'm still not sure I see the value in it)

@jrandolf
Copy link
Collaborator Author

Hmm, I think the dist folder was removed in one of the PRs by accident. Nonetheless, because of #65, I started compiling a file specifically for the website. Moving all the website code in one place would just make the codebase tidier.

@LeaVerou
Copy link
Owner

Hmm, I think the dist folder was removed in one of the PRs by accident. Nonetheless, because of #65, I started compiling a file specifically for the website. Moving all the website code in one place would just make the codebase tidier.

It was not removed accidentally, it was removed very intentionally because build artifacts should not be in the repo.
See my comment here: #65 (comment)

@jrandolf
Copy link
Collaborator Author

Closing this in favor of just moving assets.

@jrandolf jrandolf closed this Mar 15, 2023
@jrandolf jrandolf deleted the jrandolf/move-public branch March 15, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants