Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement min/maxNativeZoom (and related) options. #69

Closed
wants to merge 1 commit into from

Conversation

jkuebart
Copy link
Contributor

@jkuebart jkuebart commented Feb 4, 2017

Removed conflicts from #9.

The problem with this technique is the tight(er) coupling introduced between VectorGrid and TileLayer. This indicates that more TileLayer functionality may need to be pulled into GridLayer, or there is room for another abstract class between GridLayer and TileLayer.

Based on the low level of feedback from @IvanSanchez on related PRs I haven't looked into this so far. If there's a desire to make some architectural changes, I would be more than willing to discuss and offer support.

@jkuebart
Copy link
Contributor Author

jkuebart commented Feb 9, 2017

Closed by Leaflet/Leaflet#5319

@jkuebart jkuebart closed this Feb 9, 2017
@jkuebart jkuebart deleted the max-native-zoom branch February 9, 2017 09:51
@jkuebart
Copy link
Contributor Author

It's interesting to note that by using maxNativeZoom as implemented by GridLayer, vector tiles will not be re-rendered at higher zoom levels. Consequently, the stroke width is scaled up along with the tile, while with the previous solution given above the stroke width remained constant.

If maxNativeZoom is only used because there is sufficient detail at a particular zoom level, this might not be the intended effect. If the stroke width should remain visually constant across all zoom levels, a vector tile layer might still need to reimplement getTileSize() and createTile() accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant