Cluster stays if tapped at map borders (Android/iOS)

[TomRiedl]

The correct behavior:


This works fine if the cluster is near the center of the map.

But if I move the map to a position where the cluster is near the border of the map, this happens:

This is reproducible every time on different mobile devices (tested on two Android and three iOS devices).
This is not reproducible in Firefox and Chrome.

The app is build through PhoneGap.

The code the clusters are created:

this._map = L.map('mapNear', { worldCopyJump: true, });
this._map.options.minZoom = 1;
L.control.scale().addTo(this._map);

L.tileLayer(Application.AppCore.Configuration.MapTiles, {
    attribution: '&copy; <a href="http://osm.org/copyright">OpenStreetMap</a> contributors'
}).addTo(this._map);


this._markerCluster = new L.MarkerClusterGroup({ showCoverageOnHover: false });
for (index in items)
{
    [...]
    marker = L.marker([item.Coordinates.Latitude, item.Coordinates.Longitude],
        {
            icon: L.AwesomeMarkers.icon({ icon: item.Icon ? item.Icon : 'cube', markerColor: 'blue', prefix: 'fa', spin: false }),
            zIndexOffset: 10000
        });
    marker.bindPopup('<some html code>');
    this._markerCluster.addLayer(marker);
}
this._markerCluster.addTo(this._map);

[danzel]

https://github.com/Leaflet/Leaflet.markercluster/blob/master/src/MarkerClusterGroup.js#L892-L893
If you change this so instead of 0 it is a small number does that fix it?
Or make it always 0 and it may reproduce on desktop.

[TomRiedl]

The changes work like you expected it to happen:

With
latDiff = 0,
lngDiff = 0;
-> reproducible also on desktop.

With
latDiff = Math.abs(sw.lat - ne.lat),
lngDiff = Math.abs(sw.lng - ne.lng);
-> No bugs on mobile devices

[ftechiesnitin]

Hi @ThomasRiedl, I am facing the same issue for one of my app. Can you tell me how you fixed this issue?

Thanks.

[TomRiedl]

Hi @ftechiesnitin, I replaced
latDiff = L.Browser.mobile ? 0 : Math.abs(sw.lat - ne.lat),
lngDiff = L.Browser.mobile ? 0 : Math.abs(sw.lng - ne.lng);

with

latDiff = Math.abs(sw.lat - ne.lat),
lngDiff = Math.abs(sw.lng - ne.lng);

in file MarkerClusterGroup.js

I have to change this everytime I update Leaflet.markercluster.

[ftechiesnitin]

Thanks @TomRiedl that did the trick.

[ghybs]

Hi,

It seems sad to have to cancel the effect of mobile detection in _getExpandedVisibleBounds to prevent this bug.

It is reproducible with Leaflet 1.0.0 and MCG master: http://jsfiddle.net/3v7hd2vx/18/

It is the same issue as #344, which was solved by commit 254198a.
Unfortunately, the correction was made only in previous master branch (now leaflet-0.7 branch), but not in leaflet-master branch (now master).

Doing the same in current master branch seems to solve the issue: http://jsfiddle.net/3v7hd2vx/19/

Will do a PR shortly.

[danzel]

This works with the latest code:
http://jsfiddle.net/3v7hd2vx/192/

[danzel]

Ah, I see ghybs fixed it in #644 but it wasn't closed then. Thanks :)