New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use <button>
for controls
#7821
Comments
It may be desirable to use a CSS reset for buttons, something along the lines of: .leaflet-control button {
background-color: transparent;
border: none;
border-radius: 0;
color: inherit;
font: inherit;
line-height: inherit;
margin: 0;
padding: 0;
text-align: inherit;
text-transform: none;
-webkit-appearance: none;
-moz-appearance: none;
appearance: none;
} This is just a generic class I've been using before (inspired by normalize.css, sanitize.css, Boostrap's reboot.css), however if a default value is set for any of these properties for all controls, there's probably no reason to first reset that property. |
I only want to document this: We should not remove the existing css classes because they are used for many custom controls |
I've created a label to keep track of breaking changes like these. |
Is your feature request related to a problem? Please describe.
<button>
behaves a bit differently from<a href="#" role="button">
, this would supersede #7368 and #7369 (these describe some of the problems with<a>
controls).Describe the solution you'd like
Use
<button type="button">
over<a href="#">
for controls.Additional context
Originally posted by @mourner in #3210 (comment).
Originally posted by @jonkoops in #7368 (comment).
The text was updated successfully, but these errors were encountered: