Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mapbox API URLs and IDs in tutorials #3603

Merged
merged 1 commit into from
Jul 10, 2015
Merged

Update Mapbox API URLs and IDs in tutorials #3603

merged 1 commit into from
Jul 10, 2015

Conversation

lyzidiamond
Copy link
Contributor

  • Updates all references and URLs to the Mapbox v4 API
  • Adds a Mapbox access token associated with the mapbox Mapbox account to make v4 API requests work
  • Replaces all examples map IDs with mapbox map IDs (just mapbox.light and mapbox.streets)

Some things to note:

  • This is a straight up find-and-replace, and it will be annoying (but not impossible) when we inevitably have to rotate out the access token. Curious to see how often we have to do this -- I will keep an eye on traffic/referrers.
  • I did not change any of the tutorial language, just the URLs. If necessary, I can update language in the tutorials to add info about access tokens.

馃帳 馃悪 馃寽

@@ -64,10 +64,11 @@ The GeoJSON with state shapes was kindly shared by [Mike Bostock](http://bost.oc

Let's display our states data on a map with a custom Mapbox style for nice grayscale tiles that look perfect as a background for visualizations:

var mapboxAccessToken = {your access token here}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semicolon

@mourner
Copy link
Member

mourner commented Jul 8, 2015

Thanks a lot for the PR! Aside for minor comments, looks good to me!

@lyzidiamond
Copy link
Contributor Author

@mourner alright, I think I hit everything you mentioned. Feel free to merge or let me know if there's anything else to change!

mourner added a commit that referenced this pull request Jul 10, 2015
Update Mapbox API URLs and IDs in tutorials
@mourner mourner merged commit 4bd6bf5 into Leaflet:gh-pages Jul 10, 2015
@lyzidiamond lyzidiamond deleted the tutorials-mapbox branch January 27, 2016 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants