Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable _onZoomStart in canvas renderer #3948

Closed
wants to merge 2 commits into from

Conversation

klaftertief
Copy link
Contributor

This fixes disappearing paths when starting an animated zoom. See #3947

This fixes disappearing paths when starting an animated zoom.
@IvanSanchez
Copy link
Member

Good catch! Seems like I forgot to check the canvas renderer.

Maybe it would be a better idea to call update() only for the SVG renderer instead?

@IvanSanchez IvanSanchez added this to the 1.0-beta3 milestone Oct 16, 2015
@klaftertief
Copy link
Contributor Author

That would mean to

  • either split up the list of events in getEvents() between the base renderer and the SVG renderer
  • or have the _onZoomStart() be a noOp in the base renderer and override it in the SVG renderer.

I'm not sure what would be the cleaner way. I can update the pull request either way.

@IvanSanchez
Copy link
Member

I think splitting getEvents would be cleaner, but I'm not 100% sure (no inheritance, etc). If you could try that and see if it looks better, that'd be great.

@klaftertief
Copy link
Contributor Author

The additional commit looks a bit nicer to me then the splitter getEvents in #3950.

Though I'm not sure if this is really the best fix in general. Panning and then zooming on mobile in the debug/vector/vector-canvas.html test looks works way better in the beta 1 version. There is a slight offset movement on zoom start now.

@IvanSanchez
Copy link
Member

Superseded by #3950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants