Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new plugin: Leaflet.GeoJSONAutocomplete #4019

Merged
merged 2 commits into from
Nov 16, 2015
Merged

Add new plugin: Leaflet.GeoJSONAutocomplete #4019

merged 2 commits into from
Nov 16, 2015

Conversation

utahemre
Copy link
Contributor

This plug-in works for us successfully in several projects. I hope this will help to others.

@IvanSanchez
Copy link
Member

Looks good! Two comments, though:

  • Is it necessary to write your name in capital letters (i.e. Özkaya instead of ÖZKAYA)? I would prefer to contributors' names to be consistent in that regard.
  • Your documentation is a bit unclear on the format of the GeoJSON search service. Maybe you could add something like "Every time the user types in the search box, a query to the service is made". Also, an example of a request-response cycle would be nice IMHO.

@utahemre
Copy link
Contributor Author

Thank you very much for your interest and fast reply. I changed my name and add more detailed documentation. Please let me know if you have another comments.

IvanSanchez added a commit that referenced this pull request Nov 16, 2015
Add new plugin: Leaflet.GeoJSONAutocomplete
@IvanSanchez IvanSanchez merged commit 03a4925 into Leaflet:gh-pages Nov 16, 2015
@IvanSanchez
Copy link
Member

@utahemre ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants