Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert add/removeEventParent in documentation #4065

Closed
wants to merge 1 commit into from

Conversation

jgravois
Copy link

@jgravois jgravois commented Dec 2, 2015

  • added addEventParent() and removeEventParent() to Event Methods documentation
  • added information about fire()s optional third parameter which allows events to propogate

@mourner mourner added needs review docs Improvements or additions to documentation labels Dec 2, 2015
@IvanSanchez
Copy link
Member

addEventParent and removeEventParent do not exist in 0.7.x, which is what reference.html documents right now. These have been taken care of in the 1.0.0 docs already.

@jgravois
Copy link
Author

jgravois commented Feb 8, 2016

These have been taken care of in the 1.0.0 docs already.

ok. it took some digging but i was able to find the changes in the gh-pages-leafdoc branch in the reference-1.0.0.html file.

it looks like you're working on something new and cool to auto-generate the API reference (and maintain legacy doc at the same time). once you iron out the procedure it'd be helpful if you updated the Improving Documentation section of your CONTRIBUTING.md to give people a clue about whats going on.

IvanSanchez added a commit that referenced this pull request Feb 9, 2016
IvanSanchez added a commit that referenced this pull request Apr 2, 2016
IvanSanchez added a commit that referenced this pull request Apr 2, 2016
Added Leafdoc comments to Layer.js

Leafdoc comments for Popup, Layer

Leafdoc comments: L.Evented, inheritances, minor tilelayer

Leafdoc comments: gridlayer & tilelayer options

Leafdoc comments: tilelayer, marker drag

Typos

Leafdoc: switch to shorthand method params

Leafdoc: Switch to shorthands in marker drag, WMS.

Leafdoc: Vector layers

Leafdoc: Layer group, feature group, geojson

Leafdoc: LatLng, Point, Bounds, Icons.

Leafdoc: Controls.

Leafdoc: DOM & utils.

Leafdoc: "jake docs" now builds the documentation

Leafdoc: Commit actual templates instead of symlinks

Leafdoc: Fix broken build, have jake print out uglifyjs errors

Leafdoc: Several L.Map bits.

Leafdoc: Map handlers

Leafdoc: Map events, L.CRS, misc. fixes

Leafdoc: Fixed ordering of classes by using new leafdoc features

Leafdoc: Misc bits at the bottom of the docs

🍂doc: Map panes

🍂doc: CRSs, projections and their templates

🍂doc: miniclasses for map methods' options

Leafdoc: Cleanup L.Class, mark uninheritable sections, use Leafdoc 0.3.0

🍂doc: miniclasses for event types, bump to Leafdoc 1.0.0

🍂doc: Make linter happy after branch rebase

🍂doc: Tweaked headers for inherited stuff.

🍂doc: Tweaking section headers (white, padding, triangles)

Leafdoc: upgrade to 1.2, document SVG&Canvas, and misc bits

🍂doc: minor CSS tweaks, version in filename, typo.

Add missing bits - supersedes #4105, #4065, #4031

🍂doc: moved sections around, minor typos & fixes

Typo about LocationEvent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants