Update plugin guide to prevent some new common pitfalls #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "name": "my-leaflet-plugin", | ||
| ... | ||
| "scripts": { | ||
| "postinstall": "grunt build" |
There was a problem hiding this comment.
Actually the current best practice is to build in prepublish rather than run build on user install, so that the files get published to NPM and are available on install without devDependencies immediately.
There was a problem hiding this comment.
Hah, didn't know this (gotta update a couple of my plugins). Let me amend the commit.
|
Otherwise, 👍 |
IvanSanchez
force-pushed
the
update-plugins-guide
branch
from
f6da9cd
to
29ddd07
Compare
mourner
added a commit
that referenced
this pull request
Jan 22, 2016
Update plugin guide to prevent some new common pitfalls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen a few developers screwing up the camelCase of the factories and committing their built/minified files to their repos, and I want to prevent that from happening in the future.