Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune active tiles, fixes #3765 #4192

Closed
wants to merge 26 commits into from
Closed

Conversation

jblarsen
Copy link

@jblarsen jblarsen commented Feb 4, 2016

Please see the discussion here:

#3765

This fixes the issue. But please also see:

#3431

#3513

where the if statement was introduced. I am not sure whether my pull request will reintroduce that bug or if it will have performance implications for the use case with an opacity slider.

@IvanSanchez IvanSanchez added this to the 1.0-rc1 milestone Feb 4, 2016
@mourner
Copy link
Member

mourner commented Feb 4, 2016

I am not sure whether my pull request will reintroduce that bug or if it will have performance implications for the use case with an opacity slider.

Can you check this?

@jblarsen
Copy link
Author

jblarsen commented Feb 4, 2016

Can you check this?

I have used the sample page provided by jplante in issue #3431 to test that the bug is not reintroduced:

Leaflet master:
http://playground-leaflet.rhcloud.com/cuyi/edit?html,console,output

Code with fix:
http://playground-leaflet.rhcloud.com/bod/edit?html,console,output

Please note that the links will not work forever since the js and css files are not uploaded to a unique and persistent URL.

I will try to make two examples with an opacity slider to see what happens with the two versions.

@jblarsen
Copy link
Author

jblarsen commented Feb 4, 2016

I have made a version in which you can check out how many calls are made to the _pruneTiles method when you change the opacity:

http://playground-leaflet.rhcloud.com/kom/1/edit?html,console,output

It is only called once per opacity change (which it should). This is the same as without the change I suggest.

@IvanSanchez IvanSanchez changed the title Fixes Leaflet issue #3765 Prune active tiles, fixes #3765 Feb 4, 2016
Jesper Baasch-Larsen added 2 commits February 9, 2016 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants