-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune active tiles, fixes #3765 #4192
Conversation
Can you check this? |
I have used the sample page provided by jplante in issue #3431 to test that the bug is not reintroduced: Leaflet master: Code with fix: Please note that the links will not work forever since the js and css files are not uploaded to a unique and persistent URL. I will try to make two examples with an opacity slider to see what happens with the two versions. |
I have made a version in which you can check out how many calls are made to the _pruneTiles method when you change the opacity: http://playground-leaflet.rhcloud.com/kom/1/edit?html,console,output It is only called once per opacity change (which it should). This is the same as without the change I suggest. |
Fractional zoom controls
Fix extra tile usage
added zoomSnap for htmls
Fix for Leaflet#4208 with extra unit tests
8e5a2690d27fa955615476a4ab579f21fa.
Please see the discussion here:
#3765
This fixes the issue. But please also see:
#3431
#3513
where the if statement was introduced. I am not sure whether my pull request will reintroduce that bug or if it will have performance implications for the use case with an opacity slider.