Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added leaflet-tracksymbol to plugin page. #4219

Merged
merged 1 commit into from Feb 10, 2016
Merged

Added leaflet-tracksymbol to plugin page. #4219

merged 1 commit into from Feb 10, 2016

Conversation

ghost
Copy link

@ghost ghost commented Feb 10, 2016

I would be very happy if you add my leaflet plugin link to the plugin page.

IvanSanchez added a commit that referenced this pull request Feb 10, 2016
Added leaflet-tracksymbol to plugin page.
@IvanSanchez IvanSanchez merged commit 5d23c22 into Leaflet:gh-pages Feb 10, 2016
@IvanSanchez
Copy link
Member

Looks good! A couple of comments, though:

  • If your plugin creates a new kind of L.Marker, it should define a L.Marker.TrackMarker class, as per the Leaflet coding conventions
  • It would help a lot if you could provide a live example of the plugin in action, or at least a screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants