Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an example on map panes #4234

Merged
merged 1 commit into from
Feb 15, 2016
Merged

Conversation

@IvanSanchez IvanSanchez added in progress docs Improvements or additions to documentation labels Feb 14, 2016
@IvanSanchez
Copy link
Member Author

The question is: do we want to show an example which needs 1.0.0-beta?

***
[<img src="docs/images/labels-pane.png" class="example-img bordered-img" />][8]

### [Working with map panes][8]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add here a small label like (v1.0.0), what do you think?

@yohanboniface
Copy link
Member

Excellent! Push it up! :)

The question is: do we want to show an example which needs 1.0.0-beta?

Yes, but let's add a small label in examples list to warn about this?

@IvanSanchez
Copy link
Member Author

let's add a small label in examples list to warn about this?

@yohanboniface I've added a line of text instead. I'm such a rebel. 😛

yohanboniface added a commit that referenced this pull request Feb 15, 2016
@yohanboniface yohanboniface merged commit 62fac93 into gh-pages Feb 15, 2016
@yohanboniface
Copy link
Member

I've added a line of text instead. I'm such a rebel.

I'm so merciful that I've merged anyway ;)

@yohanboniface yohanboniface deleted the gh-pages-panes-example branch February 15, 2016 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants