Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapSpec #addLayer fix test #4245

Closed
wants to merge 1 commit into from
Closed

MapSpec #addLayer fix test #4245

wants to merge 1 commit into from

Conversation

sonic16x
Copy link

Hi. We use this tests for our code and have one problem. If layers is a lot of then .removeLayer
hasn't time to remove the layer and spy is called. We can use event 'layerremove' for this. Thanks.

@IvanSanchez
Copy link
Member

Attaching the event should be done before calling removeLayer. As it is now, removing the layer will fire an event that won't trigger any event handler.

I'm afraid to say I don't think your changes add any functionality to Leaflet 😞 - that unit test is about layeradd, not about layerremove.

@sonic16x
Copy link
Author

@IvanSanchez , I'm understood. Sorry ))

@IvanSanchez
Copy link
Member

@scherebedov No problem 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants