Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Leaflet.CountrySelect plugin #4275

Merged
merged 1 commit into from
Mar 1, 2016
Merged

Conversation

ahalota
Copy link

@ahalota ahalota commented Feb 25, 2016

No description provided.

@IvanSanchez
Copy link
Member

@ahalota I find the plugin a bit buggy - I cannot scroll the drop-down list, or drag the scrollbar (events get passed to the map). Can you fix that?

@jieter
Copy link
Contributor

jieter commented Feb 26, 2016

I can do both in the drop-down without a problem...

http://ahalota.github.io/Leaflet.CountrySelect/demo.html

@IvanSanchez
Copy link
Member

Apparently it works in chrome but fails in firefox.

@ahalota
Copy link
Author

ahalota commented Feb 26, 2016

@IvanSanchez I see now what you mean with scrolling. I will take a look this weekend about keeping focus on the div so that the mouse scroll works in Firefox as well.

As for scrolling the drop down list - When I run it in firefox, I can scroll the list with the key up/down buttons. The change event is only fired once you hit 'enter' however. I believe this is just part of how firefox handles change events on select elements

When the element loses focus after its value was changed, but not commited (e.g. after editing the value of <textarea> or <input type="text">

MDN change - event reference

@ahalota
Copy link
Author

ahalota commented Feb 26, 2016

I fixed the clicking, it shouldn't act as strange in Firefox or IE anymore.

I am still working on getting the scrollwheel to play nice. I am having trouble stopping leaflet from 'stealing' the scroll event from my dropdown in Firefox and IE. I will see what I can do about that. Thank you for the feedback.

IvanSanchez added a commit that referenced this pull request Mar 1, 2016
Added Leaflet.CountrySelect plugin
@IvanSanchez IvanSanchez merged commit 9442f9a into Leaflet:gh-pages Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants