Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prosthetic-hand unit tests #4327

Merged
merged 1 commit into from
Mar 18, 2016
Merged

prosthetic-hand unit tests #4327

merged 1 commit into from
Mar 18, 2016

Conversation

IvanSanchez
Copy link
Member

Proof of concept of unit tests for mouse events, part of what needs to be done for #3530.

This reverts the "Force PhantomJS to be non-touch" behaviour of #1434 - recent versions of PhantomJS do indeed implement TouchEvents more or less properly.

@IvanSanchez IvanSanchez force-pushed the prosthetic-hand-tests branch 5 times, most recently from 884a2b9 to 19787a8 Compare March 18, 2016 13:34
@IvanSanchez IvanSanchez changed the title WIP: prosthetic-hand unit tests prosthetic-hand unit tests Mar 18, 2016
@mourner
Copy link
Member

mourner commented Mar 18, 2016

This looks great! I see that 3 of the 4 tests are skipped on PhantomJS — is there a way to run them there? I thought this was one of the points of prosthetic-hand.

@IvanSanchez
Copy link
Member Author

@mourner They are not skipped in my setup - ensure you're using PhantomJS 2.1.1.

Also, note that 4 GridLayer/TileLayer tests are skipped due to PhantomJS not having CSS transitions support (needed for the FlyTo() tests).

@IvanSanchez
Copy link
Member Author

@mourner Phantom should skip exactly 5 tests - I made a quick amend to my commit, so that you can now run grep skipInPhamtom -r spec/ and check that, indeed, PhantomJS purposefully skips 5 tests.

This is different than skipIfNotTouch, which is meant for running the tests on Firefox (or IE or Safari), because they do not implement Touch events

@mourner
Copy link
Member

mourner commented Mar 18, 2016

👍 awesome. Let's merge.

mourner added a commit that referenced this pull request Mar 18, 2016
@mourner mourner merged commit 8e2e790 into master Mar 18, 2016
@mourner mourner deleted the prosthetic-hand-tests branch March 18, 2016 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants