Add synthetic dblclick for MS Edge with mouse #5267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, reset doubleTap status after firing a dblclick to avoid keeping an old state around. Close #5180.
|
See also #5268, an alternate approach to the same problem. |
|
Closed in favor of #5268. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I understand it, MS Edge never fires
dblclick, neither for mouse or touch, so the fix in Edge is to always fire syntheticdblclick, no matter the source of thePointerEvents.Also, we had an issue where a previous double tap would set the
DoubleTaphandlers internal state as if in a double tap, but it where never reset, so mouse events would later fire syntheticdblclicks. This PR resets thedoubleTapstatus after firing adblclickto avoid keeping an old state around.I've verified this in with mouse and touch in Edge 14, Chrome 55 and Firefox 41 on Win10.