Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding my plugin #6598

Merged
merged 3 commits into from
Apr 14, 2019
Merged

Adding my plugin #6598

merged 3 commits into from
Apr 14, 2019

Conversation

iboates
Copy link
Contributor

@iboates iboates commented Apr 14, 2019

It looks like maybe this file actually has some broken HTML on the original, unless I just can't figure out how to properly read it. I added my plugin to the "Map Events" section, since it seems like the best fit. It is a plugin which makes points get dynamically highlighted near the user's mouse cursor. Link: https://github.com/iboates/leaflet-spotlight

Copy link
Member

@IvanSanchez IvanSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTML formatting looks good to me. Will revisit if this creates any visible problem in the plugins list.

@IvanSanchez IvanSanchez merged commit de6c62e into Leaflet:master Apr 14, 2019
@iboates
Copy link
Contributor Author

iboates commented Apr 15, 2019

@IvanSanchez I suggest you roll it back so I can try it again, the page formatting has definitely broken:

https://leafletjs.com/plugins.html (scroll to Events)

@IvanSanchez
Copy link
Member

Oh, there was a missing <

@IvanSanchez
Copy link
Member

Fixed in d110509 .

Schleuse pushed a commit to Schleuse/Leaflet that referenced this pull request Dec 3, 2019
* Update plugins.md

* Update plugins.md

* Update plugins.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants