New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Bundlemon on release optimized build #7934
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Although I don't fully understand why we need a separate workflow to compare production builds — can you explain? I thought removing duplication is fixed solely by the config.
Also, nit but I wonder why we see those small +/- ~30 bytes changes in the check when the bundle itself shouldn't change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per author's comment, let's keep it in the main workflow — it seems separating it is not necessary after all.
This is because we are currently running a development build on the I think I could make it so that the main workflow also does a production build, let me experiment a little. |
Ah, I got confused by the terminology — it's still a production build (it's minified, etc.), just not a release build. Hashes are fine I think, after all both branch and |
I see the project is built by the workflow, is it possible to get access to the |
@mourner My bad, yeah I meant the release optimized build in this case, which does not include any GIT information. I split the build out into two distinct steps now, one for a release build and one for a regular build. Bundlemon will now always compare the file size of the release build (both on |
This should resolve the issues we found under #7905, namely the size check showing up twice. Also runs Bundlemon against a release optimized build to ensure that the file size is reported accurately.