Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate fix for PopUp keepInView recursion and speed up associated test #8520

Merged
merged 7 commits into from Oct 8, 2022

Commits on Oct 3, 2022

  1. Copy the full SHA
    e83e28f View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. Copy the full SHA
    b57220c View commit details
    Browse the repository at this point in the history
  2. More reliable PopupSpec's keepInView tests

    The previous test was working as a side-effect of how far it was moving. If it were movnig a short distance that still triggered a pan, the test would fail because it would have invoked animations and the map would not have immediately updated position.
    
    These tests should work reliably whether we're moving a short or long distance, so I have added a new test to cover short distances separately. I have also updated both tests to wait for the 'moveend' event, so they will continue to reliably work no matter what happens to `Map.panBy` logic in the future.
    
    After this change, the average combined runtime from both tests is 271ms. Compared to the original test, this remains a speed up from 812ms to 271ms (3x).
    rjackson committed Oct 6, 2022
    Copy the full SHA
    5415947 View commit details
    Browse the repository at this point in the history
  3. Rm unnecessary newline

    rjackson committed Oct 6, 2022
    Copy the full SHA
    586711f View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    a3d49e4 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Copy the full SHA
    09f4705 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    185b13f View commit details
    Browse the repository at this point in the history