Apply mix-blend-mode only on tile images #8907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanSanchez
requested changes
Apr 8, 2023
|
Other than my nitpicking on the CSS formatting, looks good to me. I'd like @joeberkovitz to have a look and see if #8905 is fixed satisfactorily. |
IvanSanchez
approved these changes
Apr 8, 2023
|
I have retested this and #8905 appears to be fixed by this PR, while still addressing the original concern of gaps between tiles. |
|
Nice, thanks for fixing this @Falke-Design |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8905,
mix-blend-modeissue with custom svg-tiles. The bug was introduced in #8891.Needs to be cherry-picked into
v1