Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Disallow wildcard dependencies with cargo-deny #193

Open
TimJentzsch opened this issue Jan 4, 2023 · 3 comments
Open

Disallow wildcard dependencies with cargo-deny #193

TimJentzsch opened this issue Jan 4, 2023 · 3 comments
Labels
automation-and-testing Automate everything good first issue Approachable for beginners! No special knowledge needed

Comments

@TimJentzsch
Copy link
Collaborator

We don't want to allow wildcard dependencies, as they might allow dependency upgrades with breaking changes.
However, cargo-deny currently treats all git dependencies as wildcards, even when the commit hash is fixed.

We need to wait for EmbarkStudios/cargo-deny#488 to switch this back.
Then we can change the corresponding entry in deny.toml.

@TimJentzsch TimJentzsch added automation-and-testing Automate everything blocked Cannot be advanced until something else changes labels Jan 4, 2023
@TimJentzsch TimJentzsch mentioned this issue Jan 4, 2023
4 tasks
@TimJentzsch
Copy link
Collaborator Author

This is no longer blocked, see EmbarkStudios/cargo-deny#487

We need to use the allow-wildcard-paths option in the bans section.

@TimJentzsch TimJentzsch added blocked Cannot be advanced until something else changes and removed blocked Cannot be advanced until something else changes labels Jan 11, 2023
@TimJentzsch
Copy link
Collaborator Author

Seems like the issue is not fully resolved yet.

@alice-i-cecile alice-i-cecile removed the blocked Cannot be advanced until something else changes label Feb 5, 2023
@alice-i-cecile
Copy link
Contributor

We're no longer using any git dependencies, so this is unblocked.

@alice-i-cecile alice-i-cecile added the good first issue Approachable for beginners! No special knowledge needed label May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation-and-testing Automate everything good first issue Approachable for beginners! No special knowledge needed
Projects
None yet
Development

No branches or pull requests

2 participants