Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to allow wildcard path dependencies #487

Merged
merged 6 commits into from
Dec 20, 2022
Merged

Add option to allow wildcard path dependencies #487

merged 6 commits into from
Dec 20, 2022

Conversation

sribich
Copy link
Contributor

@sribich sribich commented Dec 19, 2022

Adds an allow-wildcard-paths option for the bans check which will allow path dependencies to use wildcard versions if the crate is private or the dependency is a dev-dependency.

Resolves: #448

Adds an `allow-wildcard-paths` option for the `bans` check
which will allow path dependencies to use wildcard versions
if the crate is private or the dependency is a dev-dependency.

Closes issue #448
Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I made one minor change to also ignore wildcards if the the dependency comes from a git source, as many crates that are otherwise public and published would fail this check if a workspace uses a git patch of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ability To Ignore Path Wildcard Dependencies
2 participants