Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed instancing of log helper. #88

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

hypixus
Copy link
Contributor

@hypixus hypixus commented Feb 8, 2023

The Logger class was unnecessarily instancing itself upon calling the log preparation method createLogger.
Additionally, I done some minor formatting changes and fixed few typos.

@alepouna alepouna added enhancement New feature or request code quality This PR improves the code quality of the program labels Feb 8, 2023
Copy link
Collaborator

@alepouna alepouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alepouna
Copy link
Collaborator

alepouna commented Feb 8, 2023

Nice somehow clicked disapprove lol.

Copy link
Collaborator

@alepouna alepouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM electric boogaloo.

@LeagueOfPoro LeagueOfPoro merged commit 68dfbf2 into LeagueOfPoro:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality This PR improves the code quality of the program enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants