This repository has been archived by the owner on Sep 3, 2022. It is now read-only.
Fixed buying and selling items + packet for removing items (stack item in inventory) #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 9.82% (diff: 0.00%)@@ master #163 diff @@
=========================================
Files 100 100
Lines 8928 9161 +233
Methods 1097 1180 +83
Messages 0 0
Branches 710 771 +61
=========================================
+ Hits 898 900 +2
- Misses 8027 8250 +223
- Partials 3 11 +8
|
| @@ -96,7 +96,7 @@ public class ItemType : IBuff | |||
|
|
|||
| // Not from data | |||
| public ItemRecipe Recipe { get; private set; } | |||
| public int TotalPrice { get { return Recipe.TotalPrice; } } | |||
| public int TotalPrice { get { return getTotalItemPrice(); } } | |||
There was a problem hiding this comment.
This shouldn't be a thing, it's cached for a reason. What was wrong with the recipes total price?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #159