Forbid Run as admin usage by default.

LeagueToolkit · May 21, 2023 · 726f473 · 726f473
1 parent 317ea04
commit 726f473
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 2 deletions.
diff --git a/src/CSLOLToolsImpl.cpp b/src/CSLOLToolsImpl.cpp
@@ -226,6 +226,13 @@ void CSLOLToolsImpl::doReportError(QString name, QString message, QString trace)
     if (!trace.isEmpty()) {
         logFile_->write(trace.toUtf8() + "\n");
     }
+    if (message.contains("OpenProcess: ") || trace.contains("OpenProcess: ")) {
+        QFile file(prog_ + "/allow_admin.txt");
+        file.open(QIODevice::WriteOnly);
+        file.close();
+        trace += '\n';
+        trace += ">>Run as administrator<< is now enabled!";
+    }
     emit reportError(name, message, trace);
 }
 

diff --git a/src/CSLOLUtils.cpp b/src/CSLOLUtils.cpp
@@ -1,3 +1,4 @@
+#include <QCoreApplication>
 #include <QCryptographicHash>
 #include <QFileInfo>
 #include <QSysInfo>
@@ -99,7 +100,28 @@ QString CSLOLUtils::detectGamePath() {
     CloseHandle(snapshot);
     return "";
 }
+
+
+bool CSLOLUtils::isUnnecessaryAdmin() {
+    if (QFileInfo info(QCoreApplication::applicationDirPath() + "/allow_admin.txt"); info.exists()) {
+        return false;
+    }
+    bool result = 0;
+    HANDLE token = {};
+    if (OpenProcessToken(GetCurrentProcess(), TOKEN_QUERY, &token)) {
+        TOKEN_ELEVATION elevation = {};
+        DWORD size = sizeof(TOKEN_ELEVATION);
+        if (GetTokenInformation(token, TokenElevation, &elevation, sizeof(elevation), &size)) {
+            result = elevation.TokenIsElevated;
+        }
+        CloseHandle(token);
+    }
+    return result;
+}
 #else
 // TODO: macos implementation
 QString CSLOLUtils::detectGamePath() { return ""; }
+
+// TODO: macos implementation
+bool CSLOLUtils::isUnnecessaryAdmin() { return false; }
 #endif
diff --git a/src/CSLOLUtils.h b/src/CSLOLUtils.h
@@ -14,6 +14,7 @@ class CSLOLUtils : public QObject {
     Q_INVOKABLE QString toFile(QString file);
     Q_INVOKABLE QString checkGamePath(QString path);
     Q_INVOKABLE QString detectGamePath();
+    Q_INVOKABLE bool isUnnecessaryAdmin();
 
 private:
 };

diff --git a/src/qml/CSLOLToolBar.qml b/src/qml/CSLOLToolBar.qml
@@ -48,7 +48,7 @@ ToolBar {
             text: "\uf004"
             font.family: "FontAwesome"
             onClicked: {
-                Qt.openUrlExternally("https://github.com/morilli")
+                Qt.openUrlExternally("https://github.com/LeagueToolkit/cslol-manager/graphs/contributors")
             }
         }
         ToolButton {

diff --git a/src/qml/main.qml b/src/qml/main.qml
@@ -405,7 +405,11 @@ ApplicationWindow {
             }
         }
         firstTick = true;
-        cslolTools.init()
+        if (CSLOLUtils.isUnnecessaryAdmin()) {
+            window.showUserError("Unnecessary admin",  "Running as admin is disabled by default.\nTry running without admin at least once.")
+        } else {
+            cslolTools.init()
+        }
         cslolDialogUpdate.checkForUpdates()
     }
 }