fix: implement workaround for root privilege issues on macOS #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonshadow565
requested changes
May 25, 2023
…intf()` once Co-authored-by: moonshadow565 <moonshadow565@hotmail.com>
…slol-manager into macos_elevation_fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, users were expected to manually launch the binary contained inside of the app bundle with
sudo.This PR proposes an implementation, written in C, which explicitly asks for the user to input their password in order for the application to restart itself with root privileges. It manually overloads the
CFBundleExecutableandCFBundleNameidentifiers inside of the bundle manifest to point to the compiled binary of this elevation fix.Special thanks to @dhinakg for helping me debug a syntactical issue for
osascript -e.