Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature tidy up #91

Merged
merged 13 commits into from
Aug 21, 2019
Merged

Feature tidy up #91

merged 13 commits into from
Aug 21, 2019

Conversation

Heath101
Copy link
Contributor

@Heath101 Heath101 commented Aug 20, 2019

Might make sense to review these changes commit by commit, so that there is some context to the changes

Removed unused dependencies
Removed dependencies with security vulnerabilities
Updated a few dependencies
Replaced monologue with EventEmitter
Removed metrics instrumentation dev dependency
Fixed some eslint things
Converted to use native promises
Consolidated to use shared auto required test setup

Testing steps:

  1. Pull down the project and run the tests
  2. Open a project that uses seriate, and npm link seriate to a local version of this PR.
  3. Regression test that all the functionality works in the project the way that it should, and no errors are encounter relating to seriate.

@@ -0,0 +1 @@
8.15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, was going to suggest adding this as I got my bearings in seriate repo. Good call.

@veryfancy
Copy link
Contributor

npm depcheck output:

Missing dependencies
* tedious

Think we should add it? I gather it'll come along with the mssql package. But it is referenced directly.

@@ -1,4 +1,4 @@
/***************************************************
/** *************************************************
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears unintentional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

danged ES lint :)

@veryfancy veryfancy merged commit 7050a63 into LeanKit-Labs:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants