-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature tidy up #91
Feature tidy up #91
Conversation
@@ -0,0 +1 @@ | |||
8.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, was going to suggest adding this as I got my bearings in seriate repo. Good call.
Think we should add it? I gather it'll come along with the |
spec/behavior/external-sql.spec.js
Outdated
@@ -1,4 +1,4 @@ | |||
/*************************************************** | |||
/** ************************************************* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears unintentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
danged ES lint :)
Might make sense to review these changes commit by commit, so that there is some context to the changes
Removed unused dependencies
Removed dependencies with security vulnerabilities
Updated a few dependencies
Replaced monologue with EventEmitter
Removed metrics instrumentation dev dependency
Fixed some eslint things
Converted to use native promises
Consolidated to use shared auto required test setup
Testing steps: