Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added respect for package-lock.json begin in .gitignore #138

Merged
merged 1 commit into from
Jul 16, 2018
Merged

Added respect for package-lock.json begin in .gitignore #138

merged 1 commit into from
Jul 16, 2018

Conversation

RobertReaves
Copy link
Collaborator

@RobertReaves RobertReaves commented Jul 13, 2018 •
edited by elijahmanor
Loading

Short description of the work completed

Steps to test (if not obvious)

For Reviewer Use Only

  • Code Reviewed
  • Tests Passed
  • Coverage Reviewed
  • Feature worked as expected
  • Updated src/help.js and README.md
  • Is the version upgrade path clear for this change? (breaking vs minor vs
    patch)
  • Follow up work tracked in a card if needed

@RobertReaves RobertReaves changed the base branch from feature-respect-git-ignore to master July 13, 2018 20:58
@RobertReaves RobertReaves changed the title Added respect for .gitignore and package-lock.json Added respect for package-lock.json begin in .gitignore Jul 16, 2018
@elijahmanor elijahmanor merged commit 988831d into LeanKit-Labs:master Jul 16, 2018
@RobertReaves RobertReaves mentioned this pull request Jul 17, 2018
Closed
@RobertReaves RobertReaves deleted the feature-respect-git-ignore branch April 5, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RobertReaves @elijahmanor