Feature fetch upstream and several bug fixes #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahmanor
reviewed
Jul 11, 2017
README.md
Outdated
| The `--promote` feature also allows for an optional command-line argument of a tag in the follow form: | ||
|
|
||
| ``` | ||
| Usage: |
There was a problem hiding this comment.
This feels a little bit confusing having the Usage and Example. I understand you want to show that the v is optional. Maybe remove the Usage section and have two examples (like you do for the Usage section).
Then either have one of the following...
- a comment at the end of the 2nd example saying that the
vis optional
$ tag-release --promote 1.1.1-feature.2 # the "v" is optional - update the paragraph above the examples saying the
vis optional
The
--promotefeature also allows for an optional command-line argument (vis optional) of a tag in the follow form:
elijahmanor
reviewed
Jul 11, 2017
specs/git.spec.js
Outdated
| @@ -133,7 +134,7 @@ describe( "git", () => { | |||
| expectedRunCommandArgs: { args: "tag --sort=v:refname", logMessage: "Getting list of tags" } | |||
| }, | |||
| shortLog: { | |||
| expectedRunCommandArgs: { args: "--no-pager log --no-merges --date-order --pretty=format:'%s'", logMessage: "Parsing git log" } | |||
| expectedRunCommandArgs: { args: "--no-pager log --no-merges --date-order --pretty=format:\"%s\"", logMessage: "Parsing git log" } | |||
There was a problem hiding this comment.
Could you please update this to be surrounded by `` and then use non-escaped double quotes inside? I feel that it reads cleaner than escaped characters. Thanks
elijahmanor
reviewed
Jul 11, 2017
specs/git.spec.js
Outdated
| @@ -194,7 +195,7 @@ describe( "git", () => { | |||
| }, | |||
| generateRebaseCommitLog: { | |||
| args: "v1.1.1-blah.0", | |||
| expectedRunCommandArgs: { args: "log upstream/master..HEAD --pretty=format:'%h %s' --no-merges" } | |||
| expectedRunCommandArgs: { args: "log upstream/master..HEAD --pretty=format:\"%h %s\" --no-merges" } | |||
elijahmanor
reviewed
Jul 11, 2017
specs/git.spec.js
Outdated
| it( "should call `git.shortLog` with the appropriate options when a tag is given", () => { | ||
| return git.shortLog( "v1.2.3" ).then( () => { | ||
| expect( git.runCommand ).toHaveBeenCalledTimes( 1 ); | ||
| expect( git.runCommand ).toHaveBeenCalledWith( { args: "--no-pager log --no-merges --date-order --pretty=format:'%s' v1.2.3..", logMessage: "Parsing git log" } ); | ||
| expect( git.runCommand ).toHaveBeenCalledWith( { args: "--no-pager log --no-merges --date-order --pretty=format:\"%s\" v1.2.3..", logMessage: "Parsing git log" } ); |
elijahmanor
requested changes
Jul 11, 2017
elijahmanor
approved these changes
Jul 11, 2017
RobertReaves
force-pushed
the
feature-fetch-upstream
branch
from
a961307
to
e65d1b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the work completed
Steps to test (if not obvious)
tag-releasefrom Windows. Should work as intended.tag-release -Vandtag-release --version, you should now properly see the current version you are running oftag-releaseFor Reviewer Use Only
--helpandREADME.mdpatch)