Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed --qa step to create an upstream branch before pushing into it #77

Conversation

RobertReaves
Copy link
Collaborator

@RobertReaves RobertReaves commented Aug 16, 2017

Short description of the work completed

Removed step that caused drone to do an extra build when using the --qa feature. This was caused because we would create a branch on the upstream which would trigger a drone build and then we would push into it which would cause it to build again.

Steps to test (if not obvious)

  1. Run tag-release --qa
  2. Follow steps
  3. Should no longer create branch before pushing into it. Should create it as it is pushed into the upstream.

For Reviewer Use Only

  • Code Reviewed
  • Tests Passed
  • Coverage Reviewed
  • Feature worked as expected
  • Added or updated flags to --help and README.md
  • Does the feature work in Windows PowerShell?
  • Is the version upgrade path clear for this change? (breaking vs minor vs
    patch)
  • Follow up work tracked in a card if needed

@elijahmanor elijahmanor merged commit 087d7cc into LeanKit-Labs:defect-multiple-drone-builds Aug 16, 2017
@RobertReaves RobertReaves deleted the defect-multiple-drone-builds branch July 16, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants