Add "verbatim" option to subscribe function #106
Conversation
|
@josephfrazier - this is nit-picky, but |
|
Thanks for the feedback, @arobson. I agree that |
josephfrazier
force-pushed
the
subscribe-verbatim
branch
from
b4ab993
to
facadde
Compare
This allows non-JSON messages to be consumed by adding a line to the
queue's JSON configuration:
queues: [
{
name: queueName,
+ noParse: true,
autoDelete: true,
subscribe: true,
}
],
This option was originally named "verbatim" in commit b4ab993, but
@arobson and I agreed that "noParse" is preferable. See here:
LeanKit-Labs#106 (comment)
This allows non-JSON messages to be consumed by adding a line to the
queue's JSON configuration:
queues: [
{
name: queueName,
+ noParse: true,
autoDelete: true,
subscribe: true,
}
],
This option was originally named "verbatim" in commit b4ab993, but
@arobson and I agreed that "noParse" is preferable. See here:
LeanKit-Labs#106 (comment)
josephfrazier
force-pushed
the
subscribe-verbatim
branch
from
facadde
to
4851972
Compare
|
I got to this a little sooner than anticipated :) Mind taking a look? |
|
@josephfrazier - my apologies for how this has played out. For a lot of reasons, we've stopped active development and support of wascally. rabbot is the successor and not only supports JSON, text and byte messages by default but lets you plug in custom serializers. I really appreciate the work you put into the PR and it did help drive the development of improving serialization in rabbot. Thank you again. |
My use case involves consuming non-JSON messages sent by another client. I realize that "JSON as the only serialization provider" is one of this library's assumptions, but I'm hoping it can be made possible to bypass the JSON parsing if needed. I wasn't sure of exactly the right place to put this option, so I wanted to post what I have so far (still needs docs/tests) and get some feedback. What do you think?