-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements & Bug fixes #99
Conversation
@derickbailey - this PR should fix the issue you saw. It should also prevent multiple configure calls from running amok. |
awesome! will give this a whirl later today, hopefully. might be tomorrow, though. |
initial test of my demo code looks good. i ran 50K messages, bumping memory up to 2GB+, then ran 100 messages every 20 seconds for a little bit, and memory dropped back to 80MB! going to run this through my real system now to make sure it all works still. |
load testing on my primary system looks good! memory use jumps and drops as expected, and the full system is running smoothly with all these updates. thanks @arobson! :) |
is there an ETA on this being merged and released? I have a deploy window of Thursday, the 5th... not a huge deal if i have to run from your branch for now, though. |
@derickbailey - thought I was going crazy; and here's there already a PR and a fix. |
@dermidgen i have a sample of one of my messages here in the gist linked from #98 - honestly, though, this is a small sample json file. my production system has some messages that are 10x this size, easily. i would prefer to not have such large messages... but it is what it is, right now. |
Hope this would get merged soon. :) |
Any help needed to get this merged to trunk? |
#highfives thanks @arobson :) |
+1 Thanks! |
wascally.addExchange
#98 - No-op duplicate exchange, queue and binding declarations