Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements & Bug fixes #99

Merged
merged 9 commits into from
Nov 25, 2015
Merged

Enhancements & Bug fixes #99

merged 9 commits into from
Nov 25, 2015

Conversation

arobson
Copy link
Collaborator

@arobson arobson commented Oct 26, 2015

@arobson
Copy link
Collaborator Author

arobson commented Oct 26, 2015

@derickbailey - this PR should fix the issue you saw. It should also prevent multiple configure calls from running amok.

@mxriverlynn
Copy link
Contributor

awesome! will give this a whirl later today, hopefully. might be tomorrow, though.

@mxriverlynn
Copy link
Contributor

initial test of my demo code looks good. i ran 50K messages, bumping memory up to 2GB+, then ran 100 messages every 20 seconds for a little bit, and memory dropped back to 80MB!

going to run this through my real system now to make sure it all works still.

@mxriverlynn
Copy link
Contributor

load testing on my primary system looks good! memory use jumps and drops as expected, and the full system is running smoothly with all these updates.

thanks @arobson! :)

@mxriverlynn
Copy link
Contributor

is there an ETA on this being merged and released? I have a deploy window of Thursday, the 5th... not a huge deal if i have to run from your branch for now, though.

@dermidgen
Copy link

@derickbailey - thought I was going crazy; and here's there already a PR and a fix.
I will do some testing here as well. @derickbailey - roughly how large are the messages you're testing?
Thanks!!! @arobson

@mxriverlynn
Copy link
Contributor

@dermidgen i have a sample of one of my messages here in the gist linked from #98 - honestly, though, this is a small sample json file. my production system has some messages that are 10x this size, easily. i would prefer to not have such large messages... but it is what it is, right now.

@benjsicam
Copy link

Hope this would get merged soon. :)

@joshrivers
Copy link

Any help needed to get this merged to trunk?

arobson added a commit that referenced this pull request Nov 25, 2015
Enhancements & Bug fixes
@arobson arobson merged commit 17f24d1 into LeanKit-Labs:master Nov 25, 2015
@mxriverlynn
Copy link
Contributor

#highfives thanks @arobson :)

@joshrivers
Copy link

+1 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants