Find ASGs by DescribeTags first since DescribeAutoScalingGroups is paginated #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, that's a really good catch, I never tested it on an account with so many groups. I guess this will still remain a problem if you ever enable it on all your groups, so eventually we'd need to add pagination to most of our API calls. |
xlr-8
reviewed
Dec 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our environment has more than one page of autoscaling groups, so just iterating over a single page of results was missing the ASG I was testing with. This PR uses DescribeTags with a filter to find the ASG names that have the tag and then do a DescribeAutoScalingGroups only on those groups.