Request sender improvements #404
Conversation
Unit tests updated
# Conflicts: # Leanplum-SDK/Classes/Managers/Networking/LPFileTransferManager.m # Leanplum-SDK/Classes/Managers/Networking/LPRequestSender.h # Leanplum-SDK/Classes/Managers/Networking/LPRequestSender.m
| * Create Request Headers for network call | ||
| */ | ||
| + (NSDictionary *)createHeaders; | ||
| + (NSDictionary *)notificationSettingsToRequestParams:(NSDictionary *)settings; |
There was a problem hiding this comment.
Shouldn't this be moved to LPPushNotificationManager/Handler instead here ?
There was a problem hiding this comment.
It is only for the way those are sent in a request, I believe it should be here
| @@ -1110,22 +1111,12 @@ + (void)startWithUserId:(NSString *)userId | |||
| BOOL exitOnSuspend = [[[[NSBundle mainBundle] infoDictionary] | |||
| objectForKey:@"UIApplicationExitsOnSuspend"] boolValue]; | |||
| LPRequest *request = [LPRequestFactory stopWithParams:nil]; | |||
| [[LPRequestSender sharedInstance] sendIfConnected:request sync:exitOnSuspend]; | |||
| request.sendSynchronously = exitOnSuspend; | |||
There was a problem hiding this comment.
Get rid of sendSyncronously flag
| @@ -72,7 +72,9 @@ + (void)uploadAppIconsOnDevMode | |||
| [request onError:^(NSError *error) { | |||
| LPLog(LPError, @"Fail to upload app icons: %@", error.localizedDescription); | |||
| }]; | |||
| [[LPRequestSender sharedInstance] sendNow:request withDatas:requestDatas]; | |||
| request.datas = requestDatas; | |||
| request.requestType = Immediate; | |||
There was a problem hiding this comment.
Move requestType to be as part of the builder pattern instead setting it like this
There was a problem hiding this comment.
I agree, it will make it more clear if the request will be batched or send immediately.
| @property (atomic) BOOL sent; | ||
| @property (nonatomic, copy, nullable) LPNetworkResponseBlock responseBlock; | ||
| @property (nonatomic, copy, nullable) LPNetworkErrorBlock errorBlock; | ||
| @property (nonatomic, strong) NSString *requestId; | ||
| @property (nonatomic, assign) LPRequestType requestType; | ||
| @property (nonatomic, assign) BOOL sendSynchronously; |
There was a problem hiding this comment.
Get rid of sendSynchronously
| return true; | ||
| } | ||
|
|
||
| - (void)sendNow:(LPRequest *)request sync:(BOOL)sync |
There was a problem hiding this comment.
Please get rid off sync flag from all methods and always execute on LPOperationQueue
| [self sendNow:request withDatas:@{key: data}]; | ||
|
|
||
| [self.countAggregator incrementCount:@"send_now_with_data_lp"]; | ||
| [self sendNow:request sync:request.sendSynchronously]; |
There was a problem hiding this comment.
Please get rid off sync flag from all methods and always execute on LPOperationQueue
# Conflicts: # Example/Leanplum-SDK.xcodeproj/project.pbxproj
delete-merged-branch
bot
deleted the
SDK-51_request_sender_improvement
branch
No description provided.