Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolved issue where env vars did not overwrite php config vars #1923

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix: resolved issue where env vars did not overwrite php config vars #1923

merged 2 commits into from
Sep 28, 2023

Conversation

marcelfolaron
Copy link
Contributor

@marcelfolaron marcelfolaron commented Sep 28, 2023 •
edited

Addresses #1921 1921

@marcelfolaron marcelfolaron requested a review from a team as a code owner September 28, 2023 12:14
@marcelfolaron marcelfolaron requested review from broskees and removed request for a team September 28, 2023 12:14
broskees
broskees approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@broskees broskees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@marcelfolaron marcelfolaron merged commit 6fa3945 into master Sep 28, 2023
3 checks passed
@marcelfolaron marcelfolaron deleted the configFix branch October 9, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broskees broskees broskees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcelfolaron @broskees