Add check that a detector filth is really a Filth subclass

LeapBeyond · Sep 11, 2020 · 0fc6055 · 0fc6055
1 parent d3a3ba8
commit 0fc6055
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/scrubadub/scrubbers.py b/scrubadub/scrubbers.py
@@ -27,8 +27,11 @@ def add_detector(self, detector_cls):
             raise TypeError((
                 '"%(detector_cls)s" is not a subclass of Detector'
             ) % locals())
-        # TODO: should add tests to make sure filth_cls is actually a proper
-        # filth_cls
+        if not issubclass(detector_cls.filth_cls, Filth):
+            raise TypeError((
+                'The filth_cls "{}" in the detector "{}" is not a subclass '
+                'of Filth'
+            ).format(detector_cls.filth_cls, detector_cls))
         name = detector_cls.filth_cls.type
         if name in self._detectors:
             raise KeyError((