fix(cli-plugin-service): adjust clinet side webpack config

add 'HtmlWebpackPlugin(server side)' and 'WebpackManifestPlugin' when enable ssr
LeapFE · Apr 25, 2021 · ac2d342 · ac2d342
1 parent 5c3890a
commit ac2d342
Showing 1 changed file with 18 additions and 13 deletions.
diff --git a/packages/@luban/cli-plugin-service/src/config/plugin.ts b/packages/@luban/cli-plugin-service/src/config/plugin.ts
@@ -84,12 +84,20 @@ class Plugin implements ConfigPluginInstance {
 
       webpackConfig.plugin("client-html").use(HtmlWebpackPlugin, [htmlPluginOptions]);
 
-      webpackConfig.plugin("server-html").use(HtmlWebpackPlugin, [
-        {
-          filename: "server.ejs",
-          template: path.resolve(__dirname, "../template/dynamic/server.template.ejs"),
-        },
-      ]);
+      if (projectConfig.ssr) {
+        webpackConfig.plugin("server-html").use(HtmlWebpackPlugin, [
+          {
+            filename: "server.ejs",
+            template: path.resolve(__dirname, "../template/dynamic/server.template.ejs"),
+          },
+        ]);
+
+        webpackConfig
+          .plugin("manifest")
+          .use(WebpackManifestPlugin, [
+            { fileName: "asset-manifest.json", publicPath: projectConfig.publicPath },
+          ]);
+      }
 
       const publicDir = api.resolve("public");
       if (fs.pathExistsSync(publicDir)) {
@@ -111,12 +119,6 @@ class Plugin implements ConfigPluginInstance {
         ]);
       }
 
-      webpackConfig
-        .plugin("manifest")
-        .use(WebpackManifestPlugin, [
-          { fileName: "asset-manifest.json", publicPath: projectConfig.publicPath },
-        ]);
-
       webpackConfig
         .plugin("webpack-bar")
         .use(WebpackBar, [{ name: `[Client] ${options.projectName}`, color: "#41b883" }]);
@@ -163,7 +165,10 @@ class Plugin implements ConfigPluginInstance {
     });
 
     api.chainAllWebpack((webpackConfig, id) => {
-      webpackConfig.plugin("extract-css").use(MiniCssExtractPlugin, [extractOptions]).end();
+      webpackConfig
+        .plugin("extract-css")
+        .use(MiniCssExtractPlugin, [extractOptions])
+        .end();
 
       if (isProduction) {
         if ((args as ParsedArgs<BuildCliArgs>).report) {