Skip to content

Commit

Permalink
test: tweaked timers that were making tests not pass on mountain lion
Browse files Browse the repository at this point in the history
  • Loading branch information
@rauchg
rauchg committed Sep 4, 2012
1 parent 95303cb commit fefb643
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/engine.io.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ describe('engine', function () {

var check = setTimeout(function () {
done(new Error('Client should have ended'));
}, 20);
}, 500);

client.on('end', function () {
clearTimeout(check);
Expand All @@ -151,7 +151,7 @@ describe('engine', function () {
var check = setTimeout(function () {
client.removeListener('end', onEnd);
done();
}, 20);
}, 200);

function onEnd () {
done(new Error('Client should not end'));
Expand Down

3 comments on commit fefb643

@3rd-Eden
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test still fail randomly on Mountain Lion

  ✖ 1 of 50 tests failed:

  1) server send callback should execute in multipart packet:
     Error: expected 1 to equal 2

So there is another race condition some where.

@rauchg
Copy link
Contributor Author

@rauchg rauchg commented on fefb643 Sep 6, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mountain lion is fucked atm, it's not engine.io.

@rauchg
Copy link
Contributor Author

@rauchg rauchg commented on fefb643 Sep 6, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also revert this

Please sign in to comment.