Save doc with async validator on embedded doesn't work (Version 3.9.x)

[julien-maurel]

Hi all,
I found a new bug on async validator of embedded doc : callback of save method is called before all subdoc are checked.

The best is an example :

var mongoose=require('mongoose');
var schema = mongoose.Schema;
var db = mongoose.createConnection('mongodb://localhost/tests');

var v=function(value, cb){
    var self=this;
    console.log('IN VALID ' + value);
    setTimeout(function(){
    console.log('IN ASYNC VALID ' + value);
    cb(false);
    }, (value==='r'?1000:1500)); // First sub doc will be validate after 1s and second sub doc after 1.5s
    return true;
}

var s1 = new schema({
    title:String,
    validField:{
    type:String,
    validate:v
    }
});
var s2 = new schema({
    title:  String,
    s1:[s1]
});
var s3 = new schema({
    title:  String,
    s2:[s2]
});

var m3 = db.model('m3', s3);
var d = new m3({
    title:'test',
    s2:[
    {
        title:'test',
        s1:[
        {
            validField:'r'
        },
        {
            validField:'r2'
        }
        ]
    }
    ]
});
d.save(function(err,doc){
    console.log(JSON.stringify(err, null, 2));
    console.log(JSON.stringify(doc, null, 2));
});

On this example, normally output should be :

IN VALID r
IN VALID r2
IN ASYNC VALID r
IN ASYNC VALID r2
{
  "message": "Validation failed",
  "name": "ValidationError",
  "errors": {
    "s2.0.s1.0.validField": {
      "properties": {
        "type": "user defined",
        "message": "Validator failed for path `{PATH}` with value `{VALUE}`",
        "path": "validField",
        "value": "r"
      },
      "message": "Validator failed for path `validField` with value `r`",
      "name": "ValidatorError",
      "kind": "user defined",
      "path": "validField",
      "value": "r"
    },
    "s2.0.s1.1.validField": {
      "properties": {
        "type": "user defined",
        "message": "Validator failed for path `{PATH}` with value `{VALUE}`",
        "path": "validField",
        "value": "r2"
      },
      "message": "Validator failed for path `validField` with value `r2`",
      "name": "ValidatorError",
      "kind": "user defined",
      "path": "validField",
      "value": "r2"
    }
  },
  "key": "undefined.0.undefined.0.undefined"
}
undefined

but I have :

IN VALID r
IN VALID r2
IN ASYNC VALID r
{
  "message": "Validation failed",
  "name": "ValidationError",
  "errors": {
    "s2.0.s1.0.validField": {
      "properties": {
        "type": "user defined",
        "message": "Validator failed for path `{PATH}` with value `{VALUE}`",
        "path": "validField",
        "value": "r"
      },
      "message": "Validator failed for path `validField` with value `r`",
      "name": "ValidatorError",
      "kind": "user defined",
      "path": "validField",
      "value": "r"
    }
  },
  "key": "undefined.0.undefined.0.undefined"
}
undefined
IN ASYNC VALID r2

You can see that the save method callback is called immedialy after first sub doc validation, it doesn't wait the second sub doc validation.
This issue happend only if we call cb(false) to invalid a doc, but if I do cb(true), save callback is called at the end (but of course doc is valid ;)) :

IN VALID r
IN VALID r2
IN ASYNC VALID r
IN ASYNC VALID r2
null
{
  "__v": 0,
  "title": "test",
  "_id": "54b3a5975a6dcea50ef9b915",
  "s2": [
    {
      "title": "test",
      "_id": "54b3a5975a6dcea50ef9b916",
      "s1": [
        {
          "validField": "r",
          "_id": "54b3a5975a6dcea50ef9b918"
        },
        {
          "validField": "r2",
          "_id": "54b3a5975a6dcea50ef9b917"
        }
      ]
    }
  ]
}

Thanks

[vkarpov15]

Thanks for pointing this out, I'll see if I can repro

[julien-maurel]

Hi,
This issue is always present in 4.0.0-rc1. Do you think you can fix that quickly?