Fix filter parameter in toBuffer method #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts? |
|
Yes, you are definitely correct, the rows around check for the correct index, I must have been sloppy writing that, looks like bad copypasta. |
kangax
added a commit
that referenced
this pull request
Dec 6, 2013
Fix filter parameter in toBuffer method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to write a png to disk using a custom compressionLevel and filter method. But it always failed with
libpng error: Unknown row filter for method 0. I found this line in the code and it seems to me that the filter is using the wrong index for the parameter (args[1]is compressionLevel). So I fixed it.