Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventEmitter = process.EventEmitter is no longert valid for Node > 6.x #63

Closed
wants to merge 6 commits into from

Conversation

hawkeye64
Copy link

My approach to fixing this does not break any backwards compatibility for Node < 6.x. I have incorporated the "semver" library to determine if the version of Node being used should be one way or the other for event emitters.

Node < 6.x:
var EventEmitter = process.EventEmitter

Node >= 6.0.0
var EventEmitter = require('events')

I am using this in production.

@hawkeye64
Copy link
Author

If someone can tell me why Travis is failing on the "semver", it'd be appreciated.

@ghxst44
Copy link

ghxst44 commented Jan 10, 2018

@hawkeye64 Looks like a very old node version in Travis config. Issue with old npm version may be to blame.
From the Travis log:

$ node --version
v0.8.28
$ npm --version
1.2.30

@hawkeye64 hawkeye64 closed this Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants