Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build doesn't fail if npm run build fails #463

Closed
heyheyjp opened this issue Sep 23, 2016 · 3 comments · Fixed by #483
Closed

Build doesn't fail if npm run build fails #463

heyheyjp opened this issue Sep 23, 2016 · 3 comments · Fixed by #483
Assignees
@jeffreywescott
Labels
bug

Comments

@heyheyjp
Copy link
Collaborator

See https://codeship.com/projects/158610/builds/f6441327-6fa9-47d1-afb1-0831dc19546d
@heyheyjp heyheyjp added the bug label Sep 23, 2016
@jeffreywescott jeffreywescott changed the title Build doesn't fail if build fails Build doesn't fail if npm run build fails Sep 23, 2016
@jeffreywescott jeffreywescott self-assigned this Oct 11, 2016
@jeffreywescott
Copy link
Contributor

Ouch. What's happening here is that, when webpack was getting that error, it still returned an exit code of 0:

[jeffrey@smile game]$ NODE_ENV=production npm run postinstall

> game@0.1.4 postinstall /Users/jeffrey/dev/learnersguild/game
> npm run build


> game@0.1.4 build /Users/jeffrey/dev/learnersguild/game
> npm run symlinks && mkdir -p dist && webpack --config config/webpack.js


> game@0.1.4 symlinks /Users/jeffrey/dev/learnersguild/game
> babel-node ./scripts/createSymlinks

Deleting dir: /Users/jeffrey/dev/learnersguild/game/node_modules/src
Creating dir: /Users/jeffrey/dev/learnersguild/game/node_modules/src
Creating symlinks
Hash: 32a7b41bb6b1dac489a6
Version: webpack 1.12.14
Time: 29811ms
        Asset       Size  Chunks             Chunk Names
    vendor.js     635 kB       0  [emitted]  vendor
       app.js     624 kB       1  [emitted]  app
vendor.js.map  213 bytes       0  [emitted]  vendor
   app.js.map  244 bytes       1  [emitted]  app
   [0] multi vendor 160 bytes {0} [built]
   [0] multi app 40 bytes {1} [built]
    + 1165 hidden modules

ERROR in ./common/containers/Root/index.css
Module build failed: ReferenceError: window is not defined
    at /Users/jeffrey/dev/learnersguild/game/node_modules/style-loader/index.js!/Users/jeffrey/dev/learnersguild/game/node_modules/css-loader/index.js?sourceMap&modules&localIdentName=[name]__[local]__[hash:base64:5]&importLoaders=2!/Users/jeffrey/dev/learnersguild/game/common/containers/Root/index.css:158:31
    at /Users/jeffrey/dev/learnersguild/game/node_modules/style-loader/index.js!/Users/jeffrey/dev/learnersguild/game/node_modules/css-loader/index.js?sourceMap&modules&localIdentName=[name]__[local]__[hash:base64:5]&importLoaders=2!/Users/jeffrey/dev/learnersguild/game/common/containers/Root/index.css:153:48
    at module.exports (/Users/jeffrey/dev/learnersguild/game/node_modules/style-loader/index.js!/Users/jeffrey/dev/learnersguild/game/node_modules/css-loader/index.js?sourceMap&modules&localIdentName=[name]__[local]__[hash:base64:5]&importLoaders=2!/Users/jeffrey/dev/learnersguild/game/common/containers/Root/index.css:175:69)
    at Object.<anonymous> (/Users/jeffrey/dev/learnersguild/game/node_modules/style-loader/index.js!/Users/jeffrey/dev/learnersguild/game/node_modules/css-loader/index.js?sourceMap&modules&localIdentName=[name]__[local]__[hash:base64:5]&importLoaders=2!/Users/jeffrey/dev/learnersguild/game/common/containers/Root/index.css:54:37)
    at __webpack_require__ (/Users/jeffrey/dev/learnersguild/game/node_modules/style-loader/index.js!/Users/jeffrey/dev/learnersguild/game/node_modules/css-loader/index.js?sourceMap&modules&localIdentName=[name]__[local]__[hash:base64:5]&importLoaders=2!/Users/jeffrey/dev/learnersguild/game/common/containers/Root/index.css:21:30)
    at /Users/jeffrey/dev/learnersguild/game/node_modules/style-loader/index.js!/Users/jeffrey/dev/learnersguild/game/node_modules/css-loader/index.js?sourceMap&modules&localIdentName=[name]__[local]__[hash:base64:5]&importLoaders=2!/Users/jeffrey/dev/learnersguild/game/common/containers/Root/index.css:41:18
    at Object.<anonymous> (/Users/jeffrey/dev/learnersguild/game/node_modules/style-loader/index.js!/Users/jeffrey/dev/learnersguild/game/node_modules/css-loader/index.js?sourceMap&modules&localIdentName=[name]__[local]__[hash:base64:5]&importLoaders=2!/Users/jeffrey/dev/learnersguild/game/common/containers/Root/index.css:44:10)
    at Module._compile (module.js:413:34)
    at Object.loaderContext.exec (/Users/jeffrey/dev/learnersguild/game/node_modules/webpack-core/lib/NormalModuleMixin.js:88:7)
    at Object.<anonymous> (/Users/jeffrey/dev/learnersguild/game/node_modules/extract-text-webpack-plugin/loader.js:97:22)
    at Compiler.<anonymous> (/Users/jeffrey/dev/learnersguild/game/node_modules/webpack/lib/Compiler.js:214:10)
    at /Users/jeffrey/dev/learnersguild/game/node_modules/webpack/lib/Compiler.js:403:12
    at Compiler.next (/Users/jeffrey/dev/learnersguild/game/node_modules/tapable/lib/Tapable.js:67:11)
    at Compiler.<anonymous> (/Users/jeffrey/dev/learnersguild/game/node_modules/extract-text-webpack-plugin/loader.js:78:5)
    at Compiler.next (/Users/jeffrey/dev/learnersguild/game/node_modules/tapable/lib/Tapable.js:69:14)
    at Compiler.<anonymous> (/Users/jeffrey/dev/learnersguild/game/node_modules/webpack/lib/CachePlugin.js:40:4)
    at Compiler.applyPluginsAsync (/Users/jeffrey/dev/learnersguild/game/node_modules/tapable/lib/Tapable.js:71:13)
    at Compiler.<anonymous> (/Users/jeffrey/dev/learnersguild/game/node_modules/webpack/lib/Compiler.js:400:9)
    at Compilation.<anonymous> (/Users/jeffrey/dev/learnersguild/game/node_modules/webpack/lib/Compilation.js:577:13)
    at Compilation.applyPluginsAsync (/Users/jeffrey/dev/learnersguild/game/node_modules/tapable/lib/Tapable.js:60:69)
    at Compilation.<anonymous> (/Users/jeffrey/dev/learnersguild/game/node_modules/webpack/lib/Compilation.js:572:10)
    at Compilation.next (/Users/jeffrey/dev/learnersguild/game/node_modules/tapable/lib/Tapable.js:67:11)
    at Compilation.<anonymous> (/Users/jeffrey/dev/learnersguild/game/node_modules/webpack/lib/optimize/UglifyJsPlugin.js:140:4)
    at Compilation.applyPluginsAsync (/Users/jeffrey/dev/learnersguild/game/node_modules/tapable/lib/Tapable.js:71:13)
    at Compilation.<anonymous> (/Users/jeffrey/dev/learnersguild/game/node_modules/webpack/lib/Compilation.js:567:9)
    at Compilation.applyPluginsAsync (/Users/jeffrey/dev/learnersguild/game/node_modules/tapable/lib/Tapable.js:60:69)
    at Compilation.<anonymous> (/Users/jeffrey/dev/learnersguild/game/node_modules/webpack/lib/Compilation.js:563:8)
    at Compilation.applyPluginsAsync (/Users/jeffrey/dev/learnersguild/game/node_modules/tapable/lib/Tapable.js:60:69)
    at Compilation.seal (/Users/jeffrey/dev/learnersguild/game/node_modules/webpack/lib/Compilation.js:525:7)
    at Compiler.<anonymous> (/Users/jeffrey/dev/learnersguild/game/node_modules/webpack/lib/Compiler.js:397:15)

<LOTS OF TEXT DELETED>

Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
Child extract-text-webpack-plugin:
        + 4 hidden modules
[jeffrey@smile game]$ echo $?
0
[jeffrey@smile game]$

@jeffreywescott
Copy link
Contributor

And ... the --bail option doesn't help. :-(

https://webpack.github.io/docs/configuration.html#bail

@jeffreywescott
Copy link
Contributor

Related: webpack/webpack#708

jeffreywescott pushed a commit that referenced this issue Oct 11, 2016
ensure webpack failures fail deploy
d6dc58d 
Fixes #463. By default, Webpack doesn't fail if an error occurs -- it
returns exit code == 0. Adding a plugin fixes it. File under #WTF!
This was referenced Oct 12, 2016
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffreywescott jeffreywescott

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ensure webpack failures fail deploy LearnersGuild/echo
2 participants
@jeffreywescott @heyheyjp